Backport issue(#1156) and issue(#1057) to branch opendistro-1.2 #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TransportSettings() (opensearch-project#1057) (cherry picked from commit 70a4f70)
…etween nodes with adv sec enabled and nodes without adv sec enabled.(opensearch-project#1156) (Cherry picked from commit 9adcd20)
Codecov Report
@@ Coverage Diff @@
## opendistro-1.2 #1271 +/- ##
====================================================
+ Coverage 62.45% 62.61% +0.15%
- Complexity 2888 2907 +19
====================================================
Files 222 224 +2
Lines 15916 15967 +51
Branches 2988 2996 +8
====================================================
+ Hits 9940 9997 +57
+ Misses 4425 4417 -8
- Partials 1551 1553 +2
Continue to review full report at Codecov.
|
cliu123
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Backporting
Github Issue # or road-map entry, if available:
Description of changes:
Why these changes are required?
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
Setup Instructions
8.Is it backport from main branch? (If yes, please add backport PR # and commits #)
Yes,
Introducing passive_intertransport_auth to facilitate communication b… #1156 and commit hash is : 9adcd20
Correcting setupSslOnlyMode to use AbstractSecurityUnitTest.hasCustom… #1057 and commit hash is : 70a4f70
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.